so would the d7500 be a good choice of upgrade and my lenses will work with it?
Yes, your lenses will work with it. It uses the same sensor as the D500 but lacks some of the advanced features the D500 offers (i.e. faster buffering as well as other amenities). However, the D7500 only has 1 card slot. Your D90 only has 1 card slot, but the other D7x00 series have 2 card slots.
When Nikon made the D7500, it removed the D3x00 and D5x00 series from its lineup. The D7x00 series were more of a mid-level body. But once Nikon removed those two other series, that made the D7500 their entry level DSLR. So they removed some of the features the previous D7x00 series offered. That said ... since the D7500 shares the sensor with the D500, it has the best sensor of the Nikon DX DSLR bodies. So it should serve you very well!
The D7200 is also a great DX body with more amenities and 2 card slots, but the D7500 sensor is going to win between these two.